This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
(5.5) Fix issue with chown when only uid is specified #1789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue with upgrade failing to update permissions of a new volume if only uid is set due to an incorrect chown command (see linked ticket for more details).
I have also updated a piece of code responsible to disabling remote access (e.g. to a wizard) to tolerate "not found" errors for authorities to ensure reentrability - otherwise if a later call (e.g. deleting a trusted cluster) fails due to etcd error, the authorities won't be there and it'll fail with not found.
Type of change
Linked tickets and other PRs
TODOs
Testing done
Install a cluster, then upgrade to a new version that has this volume:
Before the change, upgrade fails with:
After the change, the upgrade passes and volume is chown'd: